diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2017-12-18 13:43:53 +0100 |
|---|---|---|
| committer | Anatoli Papirovski <apapirovski@mac.com> | 2017-12-26 12:37:19 -0500 |
| commit | ad02e0d2415681de7a42c5e841ce737d7ab9d7b3 (patch) | |
| tree | 934dacfe72db6b7b529cfeb08b01d50c84535be5 /src/env.cc | |
| parent | 15d880bcb62c628f1e7c3cc7baf659a63b312c7c (diff) | |
| download | android-node-v8-ad02e0d2415681de7a42c5e841ce737d7ab9d7b3.tar.gz android-node-v8-ad02e0d2415681de7a42c5e841ce737d7ab9d7b3.tar.bz2 android-node-v8-ad02e0d2415681de7a42c5e841ce737d7ab9d7b3.zip | |
timers: make setImmediate() immune to tampering
Make setImmediate() immune to `process` global tampering by removing
the dependency on the `process._immediateCallback` property.
PR-URL: https://github.com/nodejs/node/pull/17736
Fixes: https://github.com/nodejs/node/issues/17681
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/env.cc')
| -rw-r--r-- | src/env.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/env.cc b/src/env.cc index 97d253ae1d..c3f42302ae 100644 --- a/src/env.cc +++ b/src/env.cc @@ -311,7 +311,7 @@ void Environment::CheckImmediate(uv_check_t* handle) { MakeCallback(env->isolate(), env->process_object(), - env->immediate_callback_string(), + env->immediate_callback_function(), 0, nullptr, {0, 0}).ToLocalChecked(); |