diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-07-17 02:50:07 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-08-01 17:16:51 +0200 |
| commit | 620e46c8b59b6269784ebba42b23f23897eeedb9 (patch) | |
| tree | 6b396fdec4964d0305bbbb62195ebf56e636c78e /src/env.cc | |
| parent | 3ac94dc977b232a4502307733af2b3af60e7b102 (diff) | |
| download | android-node-v8-620e46c8b59b6269784ebba42b23f23897eeedb9.tar.gz android-node-v8-620e46c8b59b6269784ebba42b23f23897eeedb9.tar.bz2 android-node-v8-620e46c8b59b6269784ebba42b23f23897eeedb9.zip | |
src: refactor default trace writer out of agent
The agent code is supposed to manage multiple writers/clients.
Adding the default writer into the mix breaks that encapsulation.
Instead, manage default options through a separate "virtual"
default client handle, and keep the file writer management
all to the actual users.
PR-URL: https://github.com/nodejs/node/pull/21867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'src/env.cc')
| -rw-r--r-- | src/env.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/env.cc b/src/env.cc index 769676275b..244c6d8be3 100644 --- a/src/env.cc +++ b/src/env.cc @@ -105,10 +105,10 @@ void InitThreadLocalOnce() { Environment::Environment(IsolateData* isolate_data, Local<Context> context, - tracing::Agent* tracing_agent) + tracing::AgentWriterHandle* tracing_agent_writer) : isolate_(context->GetIsolate()), isolate_data_(isolate_data), - tracing_agent_(tracing_agent), + tracing_agent_writer_(tracing_agent_writer), immediate_info_(context->GetIsolate()), tick_info_(context->GetIsolate()), timer_base_(uv_now(isolate_data->event_loop())), |