diff options
| author | Anna Henningsen <anna@addaleax.net> | 2017-12-23 05:55:37 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-01-14 14:49:41 +0100 |
| commit | 9301b8a9c69d112b98c7d60e074c845d80342b4e (patch) | |
| tree | fa9f8d98fc7eca29eb6283fa303f8e71976fbb03 /src/async_wrap.h | |
| parent | 02fef8ad5a6c0e5c1ce0d4b46aa3a762935c981c (diff) | |
| download | android-node-v8-9301b8a9c69d112b98c7d60e074c845d80342b4e.tar.gz android-node-v8-9301b8a9c69d112b98c7d60e074c845d80342b4e.tar.bz2 android-node-v8-9301b8a9c69d112b98c7d60e074c845d80342b4e.zip | |
tls: make deprecated tls.createSecurePair() use public API
Make the deprecated `tls.createSecurePair()` method use other public
APIs only (`TLSSocket` in particular).
Since `tls.createSecurePair()` has been runtime-deprecated only
since Node 8, it probably isn’t quite time to remove it yet,
but this patch removes almost all of the code complexity that
is retained by it.
The API, as it is documented, is retained. However, it is very likely
that some users have come to rely on parts of undocumented API
of the `SecurePair` class, especially since some of the existing
tests checked for those. Therefore, this should definitely be
considered a breaking change.
PR-URL: https://github.com/nodejs/node/pull/17882
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Diffstat (limited to 'src/async_wrap.h')
| -rw-r--r-- | src/async_wrap.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/async_wrap.h b/src/async_wrap.h index 9b5632598b..091224f570 100644 --- a/src/async_wrap.h +++ b/src/async_wrap.h @@ -67,7 +67,6 @@ namespace node { #if HAVE_OPENSSL #define NODE_ASYNC_CRYPTO_PROVIDER_TYPES(V) \ - V(SSLCONNECTION) \ V(PBKDF2REQUEST) \ V(RANDOMBYTESREQUEST) \ V(TLSWRAP) |