diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-07-22 09:12:19 +0800 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-07-27 15:51:19 +0800 |
commit | 28a3e280eca67f906ae3b47730fe21a389b7bccb (patch) | |
tree | 18a051e45196e6d8a677dd9122470d285e3e34aa /src/async_wrap.h | |
parent | 48e5b350b3dd236353e3e8e1196a09f5c5bcda77 (diff) | |
download | android-node-v8-28a3e280eca67f906ae3b47730fe21a389b7bccb.tar.gz android-node-v8-28a3e280eca67f906ae3b47730fe21a389b7bccb.tar.bz2 android-node-v8-28a3e280eca67f906ae3b47730fe21a389b7bccb.zip |
src: add proper MemoryInfoName to wrappers
- Use camel case names for memory retainers inherited from AsyncWrap
instead of their provider names (which are all in upper case)
- Assign class names to wraps so that they appear in the heap snapshot
as nodes with class names as node names. Previously some nodes are
named with reference names, which are supposed to be edge names
instead.
PR-URL: https://github.com/nodejs/node/pull/21939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'src/async_wrap.h')
-rw-r--r-- | src/async_wrap.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/async_wrap.h b/src/async_wrap.h index f748dc801d..fed05ab021 100644 --- a/src/async_wrap.h +++ b/src/async_wrap.h @@ -174,7 +174,7 @@ class AsyncWrap : public BaseObject { v8::Local<v8::Value>* argv); virtual std::string diagnostic_name() const; - std::string MemoryInfoName() const override; + virtual std::string MemoryInfoName() const; static void WeakCallback(const v8::WeakCallbackInfo<DestroyParam> &info); |