diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-07-20 19:35:24 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-07-22 11:55:25 -0700 |
| commit | 89e4b36e62978f54b2e33b4bce8197072dbe8af1 (patch) | |
| tree | dc43dc3491aac3ddc3977612d4fb8f772e7a9592 /src/async_wrap.cc | |
| parent | 31178994140676417a4ee7d30e7f7e57e73c6873 (diff) | |
| download | android-node-v8-89e4b36e62978f54b2e33b4bce8197072dbe8af1.tar.gz android-node-v8-89e4b36e62978f54b2e33b4bce8197072dbe8af1.tar.bz2 android-node-v8-89e4b36e62978f54b2e33b4bce8197072dbe8af1.zip | |
src: make `CompiledFnEntry` a `BaseObject`
In particular:
- Move the class definition to the relevant header file,
i.e. `node_contextify.h`.
- Make sure that class instances are destroyed on
`Environment` teardown.
- Make instances of the key object traceable in heap dumps. This is
particularly relevant here because our C++ script → map key mapping
could introduce memory leaks when the import function metadata refers
back to the script in some way.
Refs: https://github.com/nodejs/node/pull/28671
PR-URL: https://github.com/nodejs/node/pull/28782
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/async_wrap.cc')
0 files changed, 0 insertions, 0 deletions