diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-04-17 23:16:22 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-04-30 00:23:33 +0200 |
commit | 723d5c058fa180684df13bd2a83bbf3ca6201957 (patch) | |
tree | 6aeb4bc88e6c437853327cced05ab797827c22f2 /src/async_wrap.cc | |
parent | 095bd569aef4fec433ddb26e681eaabff1f7fd10 (diff) | |
download | android-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.tar.gz android-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.tar.bz2 android-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.zip |
src: prefer v8::Global over node::Persistent
`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.
This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.
PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/async_wrap.cc')
-rw-r--r-- | src/async_wrap.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/async_wrap.cc b/src/async_wrap.cc index 9cfa0924c7..e822255265 100644 --- a/src/async_wrap.cc +++ b/src/async_wrap.cc @@ -35,6 +35,7 @@ using v8::EscapableHandleScope; using v8::Function; using v8::FunctionCallbackInfo; using v8::FunctionTemplate; +using v8::Global; using v8::HandleScope; using v8::Integer; using v8::Isolate; @@ -346,8 +347,8 @@ class DestroyParam { public: double asyncId; Environment* env; - Persistent<Object> target; - Persistent<Object> propBag; + Global<Object> target; + Global<Object> propBag; }; void AsyncWrap::WeakCallback(const WeakCallbackInfo<DestroyParam>& info) { |