diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2019-04-09 15:21:36 -0700 |
---|---|---|
committer | Sam Roberts <vieuxtech@gmail.com> | 2019-04-12 12:33:37 -0700 |
commit | 060d901f87b3d87314f8540eb02f315e2952f581 (patch) | |
tree | 53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/async_wrap.cc | |
parent | 7b0d8673898e65a368108264c77bccaa3e004028 (diff) | |
download | android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.tar.gz android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.tar.bz2 android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.zip |
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:
To be used, where the actual value of the Maybe is not needed, like
Object::Set.
See: https://github.com/nodejs/node/pull/26929/files#r269256335
PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/async_wrap.cc')
-rw-r--r-- | src/async_wrap.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/async_wrap.cc b/src/async_wrap.cc index 0cee1b2db1..dd84f99227 100644 --- a/src/async_wrap.cc +++ b/src/async_wrap.cc @@ -487,11 +487,11 @@ void AsyncWrap::Initialize(Local<Object> target, target->Set(context, env->async_ids_stack_string(), - env->async_hooks()->async_ids_stack().GetJSArray()).FromJust(); + env->async_hooks()->async_ids_stack().GetJSArray()).Check(); target->Set(context, FIXED_ONE_BYTE_STRING(env->isolate(), "owner_symbol"), - env->owner_symbol()).FromJust(); + env->owner_symbol()).Check(); Local<Object> constants = Object::New(isolate); #define SET_HOOKS_CONSTANT(name) \ @@ -542,7 +542,7 @@ void AsyncWrap::Initialize(Local<Object> target, instance_template->SetInternalFieldCount(1); auto function = function_template->GetFunction(env->context()).ToLocalChecked(); - target->Set(env->context(), class_name, function).FromJust(); + target->Set(env->context(), class_name, function).Check(); env->set_async_wrap_object_ctor_template(function_template); } } |