diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-07 14:52:31 +0100 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-12 06:58:29 +0800 |
| commit | 963ee0bc736008e01d80fbad973f80fd021735fd (patch) | |
| tree | c747745bbfd14b1c6bfe63f6c3488aba227c5e5a /src/api | |
| parent | 2e2670a2073c89d700ab274a47bb0e6036046e65 (diff) | |
| download | android-node-v8-963ee0bc736008e01d80fbad973f80fd021735fd.tar.gz android-node-v8-963ee0bc736008e01d80fbad973f80fd021735fd.tar.bz2 android-node-v8-963ee0bc736008e01d80fbad973f80fd021735fd.zip | |
src: rename Init and Start overloads to something more distinctive
In addition, move the `--help` and `--v8-help` processing out of
`StartNodeWithLoopAndArgs()` and process them earlier - right after
`InitializeNodeWithArgs()`, similar to how they are handled in
the legacy `Init()`.
PR-URL: https://github.com/nodejs/node/pull/26499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/api')
| -rw-r--r-- | src/api/environment.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/api/environment.cc b/src/api/environment.cc index b7a629340d..35d93f1cc8 100644 --- a/src/api/environment.cc +++ b/src/api/environment.cc @@ -225,7 +225,7 @@ Environment* CreateEnvironment(IsolateData* isolate_data, static_cast<Environment::Flags>(Environment::kIsMainThread | Environment::kOwnsProcessState | Environment::kOwnsInspector)); - env->Start(per_process::v8_is_profiling); + env->InitializeLibuv(per_process::v8_is_profiling); env->ProcessCliArgs(args, exec_args); return env; } |