diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-02-01 23:47:38 +0100 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-02-05 21:55:54 +0100 |
commit | 39eca841c30e1a54424b85f34e8dd56b2648f930 (patch) | |
tree | 2ab9c7bc285e20f85cefff16c6441c726bbed126 /src/api | |
parent | 8d63f4037e52eda125c5a70dafa602f47c13d0ad (diff) | |
download | android-node-v8-39eca841c30e1a54424b85f34e8dd56b2648f930.tar.gz android-node-v8-39eca841c30e1a54424b85f34e8dd56b2648f930.tar.bz2 android-node-v8-39eca841c30e1a54424b85f34e8dd56b2648f930.zip |
src: split ownsProcessState off isMainThread
Embedders may want to control whether a Node.js instance
controls the current process, similar to what we currently
have with `Worker`s.
Previously, the `isMainThread` flag had a bit of a double usage,
both for indicating whether we are (not) running a Worker and
whether we can modify per-process state.
PR-URL: https://github.com/nodejs/node/pull/25881
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/api')
-rw-r--r-- | src/api/environment.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/api/environment.cc b/src/api/environment.cc index e54252824b..bac3a1e42b 100644 --- a/src/api/environment.cc +++ b/src/api/environment.cc @@ -143,8 +143,12 @@ Environment* CreateEnvironment(IsolateData* isolate_data, std::vector<std::string> args(argv, argv + argc); std::vector<std::string> exec_args(exec_argv, exec_argv + exec_argc); // TODO(addaleax): Provide more sensible flags, in an embedder-accessible way. - Environment* env = - new Environment(isolate_data, context, Environment::kIsMainThread); + Environment* env = new Environment( + isolate_data, + context, + static_cast<Environment::Flags>(Environment::kIsMainThread | + Environment::kOwnsProcessState | + Environment::kOwnsInspector)); env->Start(per_process::v8_is_profiling); env->ProcessCliArgs(args, exec_args); return env; |