diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-02-24 21:52:14 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-03-05 22:40:00 +0100 |
| commit | c2f620ab76c3e42fa1fcdfde82aba7bcba3031e9 (patch) | |
| tree | 05ae336d10e36944f1d65a7f7d72aeb12f58c6b6 /src/api/environment.cc | |
| parent | cc4e8e0696ffd5813df9cb50af7b47c27aaf2712 (diff) | |
| download | android-node-v8-c2f620ab76c3e42fa1fcdfde82aba7bcba3031e9.tar.gz android-node-v8-c2f620ab76c3e42fa1fcdfde82aba7bcba3031e9.tar.bz2 android-node-v8-c2f620ab76c3e42fa1fcdfde82aba7bcba3031e9.zip | |
src: refactor `Environment::GetCurrent(isolate)` usage
Do not require an explicit `HandleScope`, or the ability to create
one, when using `Environment::GetCurrent()`.
`isolate->InContext()` is used as an indicator that it is probably
okay to create a `HandleScope`, see also the short discussion in
https://github.com/nodejs/node/pull/25775#pullrequestreview-197371049.
PR-URL: https://github.com/nodejs/node/pull/26376
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/api/environment.cc')
| -rw-r--r-- | src/api/environment.cc | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/api/environment.cc b/src/api/environment.cc index 6a56ddb511..cd3e3aefc2 100644 --- a/src/api/environment.cc +++ b/src/api/environment.cc @@ -23,6 +23,7 @@ using v8::MaybeLocal; using v8::Message; using v8::MicrotasksPolicy; using v8::ObjectTemplate; +using v8::SealHandleScope; using v8::String; using v8::Value; @@ -34,7 +35,9 @@ static bool AllowWasmCodeGenerationCallback(Local<Context> context, } static bool ShouldAbortOnUncaughtException(Isolate* isolate) { - HandleScope scope(isolate); +#ifdef DEBUG + SealHandleScope scope(isolate); +#endif Environment* env = Environment::GetCurrent(isolate); return env != nullptr && (env->is_main_thread() || !env->is_stopping_worker()) && |