diff options
author | Anna Henningsen <anna@addaleax.net> | 2018-05-27 16:41:35 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-05-31 09:54:49 +0200 |
commit | 15c7a49bfca1db23f4f7a3a79aea04a0075fbd62 (patch) | |
tree | 157b58599337e4c0d00f174e0e76b11c8b77b783 /node.gypi | |
parent | bd85844c4e80c7aa1fc02a986c7619c3956b0061 (diff) | |
download | android-node-v8-15c7a49bfca1db23f4f7a3a79aea04a0075fbd62.tar.gz android-node-v8-15c7a49bfca1db23f4f7a3a79aea04a0075fbd62.tar.bz2 android-node-v8-15c7a49bfca1db23f4f7a3a79aea04a0075fbd62.zip |
http2: switch to new runtime-controlled debugging system
Remove `--debug-http2` as a compile-time feature and
make all debug statements available using `NODE_DEBUG_NATIVE=http2`
at runtime.
This probably makes the debugging-enabled case a bit slower due to
additional string concatenations, but switching to a runtime-checking
system makes debugging more flexible and can be applied more easily
to other parts of the source code as well.
PR-URL: https://github.com/nodejs/node/pull/20987
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'node.gypi')
-rw-r--r-- | node.gypi | 4 |
1 files changed, 0 insertions, 4 deletions
@@ -90,10 +90,6 @@ 'NODE_RELEASE_URLBASE="<(node_release_urlbase)"', ] }], - [ - 'debug_http2==1', { - 'defines': [ 'NODE_DEBUG_HTTP2=1' ] - }], [ 'v8_enable_i18n_support==1', { 'defines': [ 'NODE_HAVE_I18N_SUPPORT=1' ], 'dependencies': [ |