summaryrefslogtreecommitdiff
path: root/node.gyp
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2019-11-10 16:59:16 +0800
committerAnna Henningsen <anna@addaleax.net>2019-11-19 13:43:59 +0100
commitefce655c0f1671d0e86b5c89092ac93db983ef94 (patch)
tree26af173e687a6c8ee0f26d2857742ffce01729f2 /node.gyp
parent0f78dcc86d9af8f742f76505c5a104c6dff17ca9 (diff)
downloadandroid-node-v8-efce655c0f1671d0e86b5c89092ac93db983ef94.tar.gz
android-node-v8-efce655c0f1671d0e86b5c89092ac93db983ef94.tar.bz2
android-node-v8-efce655c0f1671d0e86b5c89092ac93db983ef94.zip
module: reduce circular dependency of internal/modules/cjs/loader
Previously `internal/bootstrap/pre_execution.js` requires `internal/modules/cjs/loader.js` which in turn requires `internal/bootstrap/pre_execution.js`. This patch moves the entry point execution logic out of `pre_execution.js` and puts it into `internal/modules/run_main.js`. It also tests that `Module.runMain` can be monkey-patched before further deprecation/refactoring can be done. Also added an internal assertion `hasLoadedAnyUserCJSModule` for documentation purposes. PR-URL: https://github.com/nodejs/node/pull/30349 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'node.gyp')
-rw-r--r--node.gyp1
1 files changed, 1 insertions, 0 deletions
diff --git a/node.gyp b/node.gyp
index d37be3141b..9ae69e01df 100644
--- a/node.gyp
+++ b/node.gyp
@@ -145,6 +145,7 @@
'lib/internal/main/run_main_module.js',
'lib/internal/main/run_third_party_main.js',
'lib/internal/main/worker_thread.js',
+ 'lib/internal/modules/run_main.js',
'lib/internal/modules/cjs/helpers.js',
'lib/internal/modules/cjs/loader.js',
'lib/internal/modules/esm/loader.js',