diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-12-02 04:16:09 +0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-12-03 18:16:39 -0800 |
| commit | d17d7bdf4e3ba0e2458abcf8056e9b9ab824a04c (patch) | |
| tree | b080aed6fdfd98d18567fa90ccd20e48a08e32eb /node.gyp | |
| parent | 77618817d0e8210506f8e6e739ac7bf469122179 (diff) | |
| download | android-node-v8-d17d7bdf4e3ba0e2458abcf8056e9b9ab824a04c.tar.gz android-node-v8-d17d7bdf4e3ba0e2458abcf8056e9b9ab824a04c.tar.bz2 android-node-v8-d17d7bdf4e3ba0e2458abcf8056e9b9ab824a04c.zip | |
src: move version metadata into node_metadata{.h, .cc}
This patch moves the computation of version metadata from node.cc
into node_metadata{.h, .cc}, and creates a macro that can be
used to iterate over the available version keys (v8, uv, .etc).
This makes the code clearer as now we no longer need to add
all the headers in node.cc just to compute the versions, and
makes it easier to reuse the version definitions.
PR-URL: https://github.com/nodejs/node/pull/24774
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'node.gyp')
| -rw-r--r-- | node.gyp | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -359,6 +359,7 @@ 'src/node_http2.cc', 'src/node_i18n.cc', 'src/node_messaging.cc', + 'src/node_metadata.cc', 'src/node_native_module.cc', 'src/node_options.cc', 'src/node_os.cc', @@ -430,6 +431,7 @@ 'src/node_i18n.h', 'src/node_internals.h', 'src/node_messaging.h', + 'src/node_metadata.h', 'src/node_mutex.h', 'src/node_native_module.h', 'src/node_object_wrap.h', |