diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-11-29 05:27:18 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-12-01 07:01:51 +0800 |
| commit | 976065d9cb88a118c0238a8518a2570b28cce817 (patch) | |
| tree | a60ba9703477e4168268d4de4a9689dd4f13d8f4 /node.gyp | |
| parent | 2931c50a421473fa916c751ec298d8cae355697f (diff) | |
| download | android-node-v8-976065d9cb88a118c0238a8518a2570b28cce817.tar.gz android-node-v8-976065d9cb88a118c0238a8518a2570b28cce817.tar.bz2 android-node-v8-976065d9cb88a118c0238a8518a2570b28cce817.zip | |
lib: do not register DOMException in a module
Instead of registering it in a global scope of a native module
and expecting that it only gets evaluated when the module is actually
compiled and run and will not be evaluated because the module can
be cached, directly register the DOMException constructor
onto Environment during bootstrap for clarity, since this is
a side effect that has to happen during bootstrap.
PR-URL: https://github.com/nodejs/node/pull/24708
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'node.gyp')
0 files changed, 0 insertions, 0 deletions