summaryrefslogtreecommitdiff
path: root/node.gyp
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2019-03-08 09:34:46 +0100
committerJoyee Cheung <joyeec9h3@gmail.com>2019-03-12 07:03:53 +0800
commit0a3bcdd26108bb29045a557bc555c3a53c244a55 (patch)
treeb510257ef03b0ad2d04ed9c597677b39bce0405c /node.gyp
parent963ee0bc736008e01d80fbad973f80fd021735fd (diff)
downloadandroid-node-v8-0a3bcdd26108bb29045a557bc555c3a53c244a55.tar.gz
android-node-v8-0a3bcdd26108bb29045a557bc555c3a53c244a55.tar.bz2
android-node-v8-0a3bcdd26108bb29045a557bc555c3a53c244a55.zip
src: refactor coverage connection
- Refactor the C++ class to be resuable for other types of profiles - Move the try-catch block around coverage collection callback to be inside the callback to silence potential JSON or write errors. - Use Function::Call instead of MakeCallback to call the coverage message callback since it does not actually need async hook handling. This way we no longer needs to disable the async hooks when writing the coverage results. - Renames `lib/internal/coverage-gen/with_profiler.js` to `lib/internal/profiler.js` because it is now the only way to generate coverage. PR-URL: https://github.com/nodejs/node/pull/26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
Diffstat (limited to 'node.gyp')
-rw-r--r--node.gyp2
1 files changed, 1 insertions, 1 deletions
diff --git a/node.gyp b/node.gyp
index abae8592f4..13fa0d01e1 100644
--- a/node.gyp
+++ b/node.gyp
@@ -99,7 +99,6 @@
'lib/internal/cluster/worker.js',
'lib/internal/console/constructor.js',
'lib/internal/console/global.js',
- 'lib/internal/coverage-gen/with_profiler.js',
'lib/internal/crypto/certificate.js',
'lib/internal/crypto/cipher.js',
'lib/internal/crypto/diffiehellman.js',
@@ -168,6 +167,7 @@
'lib/internal/process/worker_thread_only.js',
'lib/internal/process/report.js',
'lib/internal/process/task_queues.js',
+ 'lib/internal/profiler.js',
'lib/internal/querystring.js',
'lib/internal/readline.js',
'lib/internal/repl.js',