summaryrefslogtreecommitdiff
path: root/node.gyp
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-04-17 23:16:22 +0200
committerMichaƫl Zasso <targos@protonmail.com>2019-04-30 08:17:33 +0200
commit33702913b1136607b1f0859375f3d2fa939fbb29 (patch)
tree48e8e5ebc02cb0ab4de18404684f7a9fc3cf6799 /node.gyp
parenteeab007b25bc7ac2225e49c13db6c7ccf1975b53 (diff)
downloadandroid-node-v8-33702913b1136607b1f0859375f3d2fa939fbb29.tar.gz
android-node-v8-33702913b1136607b1f0859375f3d2fa939fbb29.tar.bz2
android-node-v8-33702913b1136607b1f0859375f3d2fa939fbb29.zip
src: prefer v8::Global over node::Persistent
`v8::Global` is essentially a nicer variant of `node::Persistent` that, in addition to reset-on-destroy, also implements move semantics. This commit makes the necessary replacements, removes `node::Persistent` and (now-)unnecessary inclusions of the `node_persistent.h` header, and makes some of the functions that take Persistents as arguments more generic so that they work with all `v8::PersistentBase` flavours. PR-URL: https://github.com/nodejs/node/pull/27287 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'node.gyp')
-rw-r--r--node.gyp1
1 files changed, 0 insertions, 1 deletions
diff --git a/node.gyp b/node.gyp
index 3cf47ffc25..daae6afb58 100644
--- a/node.gyp
+++ b/node.gyp
@@ -606,7 +606,6 @@
'src/node_options-inl.h',
'src/node_perf.h',
'src/node_perf_common.h',
- 'src/node_persistent.h',
'src/node_platform.h',
'src/node_process.h',
'src/node_revert.h',