From 33702913b1136607b1f0859375f3d2fa939fbb29 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 17 Apr 2019 23:16:22 +0200 Subject: src: prefer v8::Global over node::Persistent `v8::Global` is essentially a nicer variant of `node::Persistent` that, in addition to reset-on-destroy, also implements move semantics. This commit makes the necessary replacements, removes `node::Persistent` and (now-)unnecessary inclusions of the `node_persistent.h` header, and makes some of the functions that take Persistents as arguments more generic so that they work with all `v8::PersistentBase` flavours. PR-URL: https://github.com/nodejs/node/pull/27287 Reviewed-By: Gus Caplan Reviewed-By: Eugene Ostroukhov Reviewed-By: Joyee Cheung Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig --- node.gyp | 1 - 1 file changed, 1 deletion(-) (limited to 'node.gyp') diff --git a/node.gyp b/node.gyp index 3cf47ffc25..daae6afb58 100644 --- a/node.gyp +++ b/node.gyp @@ -606,7 +606,6 @@ 'src/node_options-inl.h', 'src/node_perf.h', 'src/node_perf_common.h', - 'src/node_persistent.h', 'src/node_platform.h', 'src/node_process.h', 'src/node_revert.h', -- cgit v1.2.3