diff options
| author | Tobias Nießen <tniessen@tnie.de> | 2018-03-24 17:23:34 +0100 |
|---|---|---|
| committer | Tobias Nießen <tniessen@tnie.de> | 2018-03-25 03:18:56 +0200 |
| commit | eeb1b9dcb77cf5c6aeaca7fc12bd12e56012e8b5 (patch) | |
| tree | c3932198bcc609dfc31aee5ced1da6da3d17da69 /lib | |
| parent | a1c96f8e07115d3b6ff1498e7e9f530d2e0f1b6b (diff) | |
| download | android-node-v8-eeb1b9dcb77cf5c6aeaca7fc12bd12e56012e8b5.tar.gz android-node-v8-eeb1b9dcb77cf5c6aeaca7fc12bd12e56012e8b5.tar.bz2 android-node-v8-eeb1b9dcb77cf5c6aeaca7fc12bd12e56012e8b5.zip | |
Revert "process: add more version properties to release"
This reverts commit 982e3bdb1f06bf9d9926c808d30864b32a8223f9. It is
believed that the original PR should not have landed as it is as the
implemented and exposed API has a variety of flaws.
PR-URL: https://github.com/nodejs/node/pull/19577
Refs: https://github.com/nodejs/node/pull/19438
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/internal/bootstrap/node.js | 1 | ||||
| -rw-r--r-- | lib/internal/process.js | 13 |
2 files changed, 1 insertions, 13 deletions
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js index 4b5498a07d..7d7ca03d36 100644 --- a/lib/internal/bootstrap/node.js +++ b/lib/internal/bootstrap/node.js @@ -38,7 +38,6 @@ _process.setupConfig(NativeModule._source); _process.setupSignalHandlers(); _process.setupUncaughtExceptionCapture(exceptionHandlerState); - _process.setupCompareVersion(); NativeModule.require('internal/process/warning').setup(); NativeModule.require('internal/process/next_tick').setup(); NativeModule.require('internal/process/stdio').setup(); diff --git a/lib/internal/process.js b/lib/internal/process.js index b735ba2e4b..f72043264f 100644 --- a/lib/internal/process.js +++ b/lib/internal/process.js @@ -283,16 +283,6 @@ function setupUncaughtExceptionCapture(exceptionHandlerState) { }; } -function setupCompareVersion() { - const { computedVersion } = process.release; - process.release.compareVersion = (major, minor, patch) => { - const comp = (major << 16) + (minor << 8) + patch; - if (comp === computedVersion) - return 0; - return comp > computedVersion ? 1 : -1; - }; -} - module.exports = { setup_performance, setup_cpuUsage, @@ -303,6 +293,5 @@ module.exports = { setupSignalHandlers, setupChannel, setupRawDebug, - setupUncaughtExceptionCapture, - setupCompareVersion, + setupUncaughtExceptionCapture }; |