aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2016-10-26 22:41:24 -0400
committercjihrig <cjihrig@gmail.com>2016-10-29 13:29:58 -0400
commitec7c27f4cb80c3f2600ec7e024276c2831273a47 (patch)
tree27e04e1f42ee5b05e67fefd01131fa29f567297f /lib
parentd0ed173d6d3e1ee394901da167cb836ce1c83772 (diff)
downloadandroid-node-v8-ec7c27f4cb80c3f2600ec7e024276c2831273a47.tar.gz
android-node-v8-ec7c27f4cb80c3f2600ec7e024276c2831273a47.tar.bz2
android-node-v8-ec7c27f4cb80c3f2600ec7e024276c2831273a47.zip
child_process: remove unreachable code
_convertCustomFds() is only called from normalizeSpawnArguments(), which always provides an options object. Therefore, there is no need to check for options in _convertCustomFds(). PR-URL: https://github.com/nodejs/node/pull/9307 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/child_process.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/child_process.js b/lib/child_process.js
index 4c2fb7e098..afdc5ae551 100644
--- a/lib/child_process.js
+++ b/lib/child_process.js
@@ -305,7 +305,7 @@ var _deprecatedCustomFds = internalUtil.deprecate(function(options) {
'Use options.stdio instead.');
function _convertCustomFds(options) {
- if (options && options.customFds && !options.stdio) {
+ if (options.customFds && !options.stdio) {
_deprecatedCustomFds(options);
}
}