diff options
author | Sergey Golovin <golovim@gmail.com> | 2018-02-13 14:49:53 +0300 |
---|---|---|
committer | Matheus Marchini <matheus@sthima.com> | 2018-02-16 13:35:36 -0200 |
commit | d8d84eee18800f60e477e6ad6fb35c14f054f7f9 (patch) | |
tree | 8ea81fd37045fbbea2af20c7afb67a7b7198a4fc /lib | |
parent | 759a083d4497b6300be720029cb5b2004e4637b1 (diff) | |
download | android-node-v8-d8d84eee18800f60e477e6ad6fb35c14f054f7f9.tar.gz android-node-v8-d8d84eee18800f60e477e6ad6fb35c14f054f7f9.tar.bz2 android-node-v8-d8d84eee18800f60e477e6ad6fb35c14f054f7f9.zip |
fs: replace magic numbers by named constants
PR-URL: https://github.com/nodejs/node/pull/18757
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/fs.js | 10 |
1 files changed, 8 insertions, 2 deletions
@@ -46,6 +46,10 @@ const { assertEncoding, stringToFlags } = internalFS; +const { + CHAR_FORWARD_SLASH, + CHAR_BACKWARD_SLASH, +} = require('internal/constants'); Object.defineProperty(exports, 'constants', { configurable: false, @@ -1796,7 +1800,7 @@ if (isWindows) { } else { splitRoot = function splitRoot(str) { for (var i = 0; i < str.length; ++i) { - if (str.charCodeAt(i) !== 47/*'/'*/) + if (str.charCodeAt(i) !== CHAR_FORWARD_SLASH) return str.slice(0, i); } return str; @@ -1820,7 +1824,9 @@ if (isWindows) { nextPart = function nextPart(p, i) { for (; i < p.length; ++i) { const ch = p.charCodeAt(i); - if (ch === 92/*'\'*/ || ch === 47/*'/'*/) + + // Check for a separator character + if (ch === CHAR_BACKWARD_SLASH || ch === CHAR_FORWARD_SLASH) return i; } return -1; |