diff options
author | Weijia Wang <381152119@qq.com> | 2017-12-12 09:27:35 +0800 |
---|---|---|
committer | Weijia Wang <381152119@qq.com> | 2017-12-29 12:33:34 +0800 |
commit | c64ca56def8651c2ad679bcdf1283fa7560e88f3 (patch) | |
tree | 5556fcf9b3f2175b745633e088f62017a32ee6de /lib | |
parent | f94eec0218419a639c6c0019d8e4a48a894f7aff (diff) | |
download | android-node-v8-c64ca56def8651c2ad679bcdf1283fa7560e88f3.tar.gz android-node-v8-c64ca56def8651c2ad679bcdf1283fa7560e88f3.tar.bz2 android-node-v8-c64ca56def8651c2ad679bcdf1283fa7560e88f3.zip |
util: improve error message of _errnoException
The usage of ERR_INVALID_ARG_TYPE in _errnoException
is a little inappropriate. This change is to improve it.
PR-URL: https://github.com/nodejs/node/pull/17626
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/util.js | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/lib/util.js b/lib/util.js index f9c33a759f..e0cdc2c28f 100644 --- a/lib/util.js +++ b/lib/util.js @@ -1056,9 +1056,12 @@ function error(...args) { } function _errnoException(err, syscall, original) { - if (typeof err !== 'number' || err >= 0 || !Number.isSafeInteger(err)) { - throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err', - 'negative number'); + if (typeof err !== 'number') { + throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err', 'number', err); + } + if (err >= 0 || !Number.isSafeInteger(err)) { + throw new errors.RangeError('ERR_OUT_OF_RANGE', 'err', + 'a negative integer', err); } const name = errname(err); var message = `${syscall} ${name}`; |