summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2019-02-01 08:28:05 +0800
committerJoyee Cheung <joyeec9h3@gmail.com>2019-02-08 08:09:56 +0800
commitb44131ab927008edff85a9efb196e1e192d28a29 (patch)
tree2a466221bbcf86f291903df54f5800b1e196f13d /lib
parent09a5f0252ed8e367dd29ba77e2931e5cf2a39a9e (diff)
downloadandroid-node-v8-b44131ab927008edff85a9efb196e1e192d28a29.tar.gz
android-node-v8-b44131ab927008edff85a9efb196e1e192d28a29.tar.bz2
android-node-v8-b44131ab927008edff85a9efb196e1e192d28a29.zip
lib: use `internal/options` to query `--abort-on-uncaught-exception`
Instead of using `internalBinding('config').shouldAbortOnUncaughtException`. Also removes that property from the binding. PR-URL: https://github.com/nodejs/node/pull/25862 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/internal/async_hooks.js7
-rw-r--r--lib/internal/policy/manifest.js4
2 files changed, 9 insertions, 2 deletions
diff --git a/lib/internal/async_hooks.js b/lib/internal/async_hooks.js
index d382fe36e1..165d44b702 100644
--- a/lib/internal/async_hooks.js
+++ b/lib/internal/async_hooks.js
@@ -4,6 +4,11 @@ const {
ERR_ASYNC_TYPE,
ERR_INVALID_ASYNC_ID
} = require('internal/errors').codes;
+
+const { getOptionValue } = require('internal/options');
+const shouldAbortOnUncaughtException =
+ getOptionValue('--abort-on-uncaught-exception');
+
const async_wrap = internalBinding('async_wrap');
/* async_hook_fields is a Uint32Array wrapping the uint32_t array of
* Environment::AsyncHooks::fields_[]. Each index tracks the number of active
@@ -107,7 +112,7 @@ function fatalError(e) {
Error.captureStackTrace(o, fatalError);
process._rawDebug(o.stack);
}
- if (internalBinding('config').shouldAbortOnUncaughtException) {
+ if (shouldAbortOnUncaughtException) {
process.abort();
}
process.exit(1);
diff --git a/lib/internal/policy/manifest.js b/lib/internal/policy/manifest.js
index f6adca125b..6c777a7c78 100644
--- a/lib/internal/policy/manifest.js
+++ b/lib/internal/policy/manifest.js
@@ -25,7 +25,9 @@ const { entries } = Object;
const kIntegrities = new SafeWeakMap();
const kReactions = new SafeWeakMap();
const kRelativeURLStringPattern = /^\.{0,2}\//;
-const { shouldAbortOnUncaughtException } = internalBinding('config');
+const { getOptionValue } = require('internal/options');
+const shouldAbortOnUncaughtException =
+ getOptionValue('--abort-on-uncaught-exception');
const { abort, exit, _rawDebug } = process;
function REACTION_THROW(error) {