diff options
author | Jackson Tian <shyvo1987@gmail.com> | 2015-12-18 10:57:21 +0800 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2016-03-27 09:14:48 -0700 |
commit | afd821a91d14a13becdf989184adf721ae7365eb (patch) | |
tree | 1ee44c3bc4d82894bbbe3d904f86e8a228c3acde /lib | |
parent | 26a4a4bc93d1d79e7deb074a97ceeaf6cd4131dd (diff) | |
download | android-node-v8-afd821a91d14a13becdf989184adf721ae7365eb.tar.gz android-node-v8-afd821a91d14a13becdf989184adf721ae7365eb.tar.bz2 android-node-v8-afd821a91d14a13becdf989184adf721ae7365eb.zip |
buffer: faster case for create buffer from empty string
When create Buffer from empty string will touch
C++ binding also.
This patch can improve edge case ~70% faster.
PR-URL: https://github.com/nodejs/node/pull/4414
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/buffer.js | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/buffer.js b/lib/buffer.js index 2fe13303f6..a83361cc9b 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -212,6 +212,10 @@ function fromString(string, encoding) { throw new TypeError('"encoding" must be a valid string encoding'); var length = byteLength(string, encoding); + + if (length === 0) + return Buffer.alloc(0); + if (length >= (Buffer.poolSize >>> 1)) return binding.createFromString(string, encoding); |