worker: fix process._fatalException return type

This makes sure `process._fatalException()` returns a boolean when
run inside of a worker.

PR-URL: https://github.com/nodejs/node/pull/29706
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

1 files changed, 21 insertions, 19 deletions

diff --git a/lib/internal/main/worker_thread.js b/lib/internal/main/worker_thread.js
index 90e84f204b..50a19be77d 100644
--- a/lib/internal/main/worker_thread.js
+++ b/lib/internal/main/worker_thread.js
@@ -166,26 +166,28 @@ function workerOnGlobalUncaughtException(error, fromPromise) {
   }
   debug(`[${threadId}] uncaught exception handled = ${handled}`);
 
-  if (!handled) {
-    let serialized;
-    try {
-      const { serializeError } = require('internal/error-serdes');
-      serialized = serializeError(error);
-    } catch {}
-    debug(`[${threadId}] uncaught exception serialized = ${!!serialized}`);
-    if (serialized)
-      port.postMessage({
-        type: ERROR_MESSAGE,
-        error: serialized
-      });
-    else
-      port.postMessage({ type: COULD_NOT_SERIALIZE_ERROR });
-
-    const { clearAsyncIdStack } = require('internal/async_hooks');
-    clearAsyncIdStack();
-
-    process.exit();
+  if (handled) {
+    return true;
   }
+
+  let serialized;
+  try {
+    const { serializeError } = require('internal/error-serdes');
+    serialized = serializeError(error);
+  } catch {}
+  debug(`[${threadId}] uncaught exception serialized = ${!!serialized}`);
+  if (serialized)
+    port.postMessage({
+      type: ERROR_MESSAGE,
+      error: serialized
+    });
+  else
+    port.postMessage({ type: COULD_NOT_SERIALIZE_ERROR });
+
+  const { clearAsyncIdStack } = require('internal/async_hooks');
+  clearAsyncIdStack();
+
+  process.exit();
 }
 
 // Patch the global uncaught exception handler so it gets picked up by