diff options
author | Rich Trott <rtrott@gmail.com> | 2018-11-02 00:11:54 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-11-13 14:38:23 -0800 |
commit | ad6ead3aab24e6b703d4982ba0563a15561a2915 (patch) | |
tree | 69a1582401f2de01b4e87df1d84486432e736676 /lib | |
parent | a2c2c78e097c4e1036eb24abd620a52c709a9467 (diff) | |
download | android-node-v8-ad6ead3aab24e6b703d4982ba0563a15561a2915.tar.gz android-node-v8-ad6ead3aab24e6b703d4982ba0563a15561a2915.tar.bz2 android-node-v8-ad6ead3aab24e6b703d4982ba0563a15561a2915.zip |
Revert "child_process: change windowsHide default to true"
This reverts commit 420d8afe3db22ad703e74892f58f9e32d34ff699.
PR-URL: https://github.com/nodejs/node/pull/24034
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/child_process.js | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/child_process.js b/lib/child_process.js index e2b7a32920..711764dba7 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -224,7 +224,7 @@ exports.execFile = function execFile(file /* , args, options, callback */) { gid: options.gid, uid: options.uid, shell: options.shell, - windowsHide: options.windowsHide !== false, + windowsHide: !!options.windowsHide, windowsVerbatimArguments: !!options.windowsVerbatimArguments }); @@ -544,7 +544,7 @@ var spawn = exports.spawn = function spawn(/* file, args, options */) { file: opts.file, args: opts.args, cwd: options.cwd, - windowsHide: options.windowsHide !== false, + windowsHide: !!options.windowsHide, windowsVerbatimArguments: !!options.windowsVerbatimArguments, detached: !!options.detached, envPairs: opts.envPairs, @@ -578,8 +578,6 @@ function spawnSync(/* file, args, options */) { options.stdio = _validateStdio(options.stdio || 'pipe', true).stdio; - options.windowsHide = options.windowsHide !== false; - if (options.input) { var stdin = options.stdio[0] = util._extend({}, options.stdio[0]); stdin.input = options.input; |