diff options
author | cjihrig <cjihrig@gmail.com> | 2019-08-17 13:02:53 -0400 |
---|---|---|
committer | cjihrig <cjihrig@gmail.com> | 2019-08-19 15:13:34 -0400 |
commit | 9f9a201cc67d09c7c61169f9e274a76afd4159fe (patch) | |
tree | 58bda4ccab6e681bb73736ec27548b76f71341f9 /lib | |
parent | 9c27118c20cf63de7637092955e5e41de7aa3316 (diff) | |
download | android-node-v8-9f9a201cc67d09c7c61169f9e274a76afd4159fe.tar.gz android-node-v8-9f9a201cc67d09c7c61169f9e274a76afd4159fe.tar.bz2 android-node-v8-9f9a201cc67d09c7c61169f9e274a76afd4159fe.zip |
fs: validate writev fds consistently
This commit updates the recently added writev methods
to validate file descriptors like the other fs methods do.
PR-URL: https://github.com/nodejs/node/pull/29185
Refs: https://github.com/nodejs/node/pull/25925
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/fs.js | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -625,7 +625,7 @@ function writev(fd, buffers, position, callback) { callback(err, written || 0, buffers); } - validateUint32(fd, 'fd'); + validateInt32(fd, 'fd', 0); if (!isBuffersArray(buffers)) { throw new ERR_INVALID_ARG_TYPE('buffers', 'ArrayBufferView[]', buffers); @@ -650,7 +650,7 @@ Object.defineProperty(writev, internalUtil.customPromisifyArgs, { // fs.writevSync(fd, buffers[, position]); function writevSync(fd, buffers, position) { - validateUint32(fd, 'fd'); + validateInt32(fd, 'fd', 0); const ctx = {}; if (!isBuffersArray(buffers)) { |