fs: throw writeSync errors in JS

PR-URL: https://github.com/nodejs/node/pull/19041
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 13 insertions, 6 deletions

diff --git a/lib/fs.js b/lib/fs.js
index 0671a05ae0..2c96b08144 100644
--- a/lib/fs.js
+++ b/lib/fs.js
@@ -635,6 +635,8 @@ Object.defineProperty(fs.write, internalUtil.customPromisifyArgs,
 //  fs.writeSync(fd, string[, position[, encoding]]);
 fs.writeSync = function(fd, buffer, offset, length, position) {
   validateUint32(fd, 'fd');
+  const ctx = {};
+  let result;
   if (isUint8Array(buffer)) {
     if (position === undefined)
       position = null;
@@ -643,13 +645,18 @@ fs.writeSync = function(fd, buffer, offset, length, position) {
     if (typeof length !== 'number')
       length = buffer.length - offset;
     validateOffsetLengthWrite(offset, length, buffer.byteLength);
-    return binding.writeBuffer(fd, buffer, offset, length, position);
+    result = binding.writeBuffer(fd, buffer, offset, length, position,
+                                 undefined, ctx);
+  } else {
+    if (typeof buffer !== 'string')
+      buffer += '';
+    if (offset === undefined)
+      offset = null;
+    result = binding.writeString(fd, buffer, offset, length,
+                                 undefined, ctx);
   }
-  if (typeof buffer !== 'string')
-    buffer += '';
-  if (offset === undefined)
-    offset = null;
-  return binding.writeString(fd, buffer, offset, length, position);
+  handleErrorFromBinding(ctx);
+  return result;
 };
 
 fs.rename = function(oldPath, newPath, callback) {