summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorJames M Snell <jasnell@gmail.com>2017-11-26 13:35:06 -0800
committerJames M Snell <jasnell@gmail.com>2017-12-13 13:26:33 -0800
commit956f97b875c9d5193395c70b378c8e1bcedca08e (patch)
treec678fcb78d8c3ee321bef62a2d1a09e279fb821d /lib
parent639096855ed52958a5bf7ccc0a83cee6a4a24166 (diff)
downloadandroid-node-v8-956f97b875c9d5193395c70b378c8e1bcedca08e.tar.gz
android-node-v8-956f97b875c9d5193395c70b378c8e1bcedca08e.tar.bz2
android-node-v8-956f97b875c9d5193395c70b378c8e1bcedca08e.zip
fs: move type checking for fs.fdatasync to js
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/fs.js4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/fs.js b/lib/fs.js
index ac0d42c76a..70e0d3d98c 100644
--- a/lib/fs.js
+++ b/lib/fs.js
@@ -907,7 +907,7 @@ fs.rmdirSync = function(path) {
};
fs.fdatasync = function(fd, callback) {
- if (typeof fd !== 'number')
+ if (!Number.isInteger(fd))
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'fd', 'number');
if (fd < 0 || fd > 0xFFFFFFFF)
throw new errors.RangeError('ERR_OUT_OF_RANGE', 'fd');
@@ -917,7 +917,7 @@ fs.fdatasync = function(fd, callback) {
};
fs.fdatasyncSync = function(fd) {
- if (typeof fd !== 'number')
+ if (!Number.isInteger(fd))
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'fd', 'number');
if (fd < 0 || fd > 0xFFFFFFFF)
throw new errors.RangeError('ERR_OUT_OF_RANGE', 'fd');