diff options
author | Luigi Pinca <luigipinca@gmail.com> | 2019-10-20 07:21:50 +0200 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-10-22 13:37:56 -0500 |
commit | 94230d15bdbfe229901b221feb5814b60f8eeedb (patch) | |
tree | ef9af429ce16e2b81a5126584dbce85defa1be38 /lib | |
parent | 4201cdde89af76d80ec794e82ee0b1c47c107299 (diff) | |
download | android-node-v8-94230d15bdbfe229901b221feb5814b60f8eeedb.tar.gz android-node-v8-94230d15bdbfe229901b221feb5814b60f8eeedb.tar.bz2 android-node-v8-94230d15bdbfe229901b221feb5814b60f8eeedb.zip |
stream: remove dead code
`String.prototype.split()` returns an array of strings so the branch is
never taken.
Fixes: https://github.com/nodejs/node/issues/30040
PR-URL: https://github.com/nodejs/node/pull/30041
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/stream.js | 31 |
1 files changed, 13 insertions, 18 deletions
diff --git a/lib/stream.js b/lib/stream.js index 826f0e6d9a..ff8838f425 100644 --- a/lib/stream.js +++ b/lib/stream.js @@ -43,23 +43,18 @@ Stream.Stream = Stream; Stream._isUint8Array = require('internal/util/types').isUint8Array; -const version = process.version.substr(1).split('.'); -if (version[0] === 0 && version[1] < 12) { - Stream._uint8ArrayToBuffer = Buffer; -} else { - try { - const internalBuffer = require('internal/buffer'); - Stream._uint8ArrayToBuffer = function _uint8ArrayToBuffer(chunk) { - return new internalBuffer.FastBuffer(chunk.buffer, - chunk.byteOffset, - chunk.byteLength); - }; - } catch (e) { // eslint-disable-line no-unused-vars - } +try { + const internalBuffer = require('internal/buffer'); + Stream._uint8ArrayToBuffer = function _uint8ArrayToBuffer(chunk) { + return new internalBuffer.FastBuffer(chunk.buffer, + chunk.byteOffset, + chunk.byteLength); + }; +} catch (e) { // eslint-disable-line no-unused-vars +} - if (!Stream._uint8ArrayToBuffer) { - Stream._uint8ArrayToBuffer = function _uint8ArrayToBuffer(chunk) { - return Buffer.prototype.slice.call(chunk); - }; - } +if (!Stream._uint8ArrayToBuffer) { + Stream._uint8ArrayToBuffer = function _uint8ArrayToBuffer(chunk) { + return Buffer.prototype.slice.call(chunk); + }; } |