diff options
| author | leeight <leeight@gmail.com> | 2018-11-21 16:53:15 +0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-24 18:19:11 -0800 |
| commit | 895fe2f574cc09eaadb8e9157c46751d9cdf7e51 (patch) | |
| tree | ed144c12106bbad3f481e85070c0c0e2a6865bd6 /lib | |
| parent | a57343c72730bc26086fa3e358581e0ade4849d0 (diff) | |
| download | android-node-v8-895fe2f574cc09eaadb8e9157c46751d9cdf7e51.tar.gz android-node-v8-895fe2f574cc09eaadb8e9157c46751d9cdf7e51.tar.bz2 android-node-v8-895fe2f574cc09eaadb8e9157c46751d9cdf7e51.zip | |
http2: fix session[kSession] undefined issue
`finishSessionDestroy` session cleanup when already done.
PR-URL: https://github.com/nodejs/node/pull/24547
Fixes: https://github.com/nodejs/node/issues/24546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/internal/http2/core.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js index 0302d535c3..a020838493 100644 --- a/lib/internal/http2/core.js +++ b/lib/internal/http2/core.js @@ -1989,6 +1989,7 @@ class Http2Stream extends Duplex { // attempt to gracefully close the session. const state = this[kState]; if (this.headersSent && + this[kSession] && this[kSession][kType] === NGHTTP2_SESSION_SERVER && !(state.flags & STREAM_FLAGS_HAS_TRAILERS) && !state.didRead && |