diff options
| author | cjihrig <cjihrig@gmail.com> | 2016-10-27 17:37:40 -0400 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2016-10-31 15:51:57 -0400 |
| commit | 7f909c3b7922a3c7cdca03527dd6dc3687ae4e8b (patch) | |
| tree | e3d70cdaeeff4daea631ad18bd494ee44606d35e /lib | |
| parent | feb3531d912586099812c2962bc99173d5ef22b1 (diff) | |
| download | android-node-v8-7f909c3b7922a3c7cdca03527dd6dc3687ae4e8b.tar.gz android-node-v8-7f909c3b7922a3c7cdca03527dd6dc3687ae4e8b.tar.bz2 android-node-v8-7f909c3b7922a3c7cdca03527dd6dc3687ae4e8b.zip | |
events: remove unnecessary checks
This commit removes two truthy checks for object properties that
are immediately followed by a strict equality check. The other
item in the comparison is guaranteed to be a function by this
point in the code, so the truthy check is redundant.
PR-URL: https://github.com/nodejs/node/pull/9330
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/events.js | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/events.js b/lib/events.js index da2dc599ca..e7202bfedd 100644 --- a/lib/events.js +++ b/lib/events.js @@ -327,7 +327,7 @@ EventEmitter.prototype.removeListener = if (!list) return this; - if (list === listener || (list.listener && list.listener === listener)) { + if (list === listener || list.listener === listener) { if (--this._eventsCount === 0) this._events = new EventHandlers(); else { @@ -339,8 +339,7 @@ EventEmitter.prototype.removeListener = position = -1; for (i = list.length; i-- > 0;) { - if (list[i] === listener || - (list[i].listener && list[i].listener === listener)) { + if (list[i] === listener || list[i].listener === listener) { originalListener = list[i].listener; position = i; break; |