summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorleeight <leeight@gmail.com>2018-11-17 23:12:59 +0800
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-11-20 06:05:56 +0100
commit771585fcf5b1fe0940ed99d5f0c738ae80194b16 (patch)
treee5094287c5e24012b0cebfb64b3c51fb3cfacb74 /lib
parent47495e089aedc0e9cf6bf8380ff8827e58fb36b5 (diff)
downloadandroid-node-v8-771585fcf5b1fe0940ed99d5f0c738ae80194b16.tar.gz
android-node-v8-771585fcf5b1fe0940ed99d5f0c738ae80194b16.tar.bz2
android-node-v8-771585fcf5b1fe0940ed99d5f0c738ae80194b16.zip
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to `setupInspector` and remove the argument from `setupInspector`. PR-URL: https://github.com/nodejs/node/pull/24446 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/internal/bootstrap/node.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 85bfc688b3..21544bceb4 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -439,7 +439,6 @@
function setupGlobalConsole() {
const originalConsole = global.console;
- const CJSModule = NativeModule.require('internal/modules/cjs/loader');
// Setup Node.js global.console.
const wrappedConsole = NativeModule.require('console');
Object.defineProperty(global, 'console', {
@@ -448,7 +447,7 @@
value: wrappedConsole,
writable: true
});
- setupInspector(originalConsole, wrappedConsole, CJSModule);
+ setupInspector(originalConsole, wrappedConsole);
}
function setupGlobalURL() {
@@ -521,10 +520,11 @@
NativeModule.require('internal/domexception');
}
- function setupInspector(originalConsole, wrappedConsole, CJSModule) {
+ function setupInspector(originalConsole, wrappedConsole) {
if (!process.config.variables.v8_enable_inspector) {
return;
}
+ const CJSModule = NativeModule.require('internal/modules/cjs/loader');
const { addCommandLineAPI, consoleCall } = process.binding('inspector');
// Setup inspector command line API.
const { makeRequireFunction } =