tls: don't push() incoming data when ondata is set

Otherwise the data ends up "on the wire" twice, and
switching between consuming the stream using `ondata`
vs. `read()` would yield duplicate data, which was bad.

1 files changed, 4 insertions, 5 deletions

diff --git a/lib/tls.js b/lib/tls.js
index 976ff46352..a758c8e01c 100644
--- a/lib/tls.js
+++ b/lib/tls.js
@@ -505,16 +505,15 @@ CryptoStream.prototype._read = function read(size) {
   } else {
     // Give them requested data
     if (this.ondata) {
-      var self = this;
       this.ondata(pool, start, start + bytesRead);
 
       // Consume data automatically
       // simple/test-https-drain fails without it
-      process.nextTick(function() {
-        self.read(bytesRead);
-      });
+      this.push(pool.slice(start, start + bytesRead));
+      this.read(bytesRead);
+    } else {
+      this.push(pool.slice(start, start + bytesRead));
     }
-    this.push(pool.slice(start, start + bytesRead));
   }
 
   // Let users know that we've some internal data to read