diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-11 03:28:35 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-13 20:01:10 +0200 |
| commit | 710110788b92311a9a012ede812ac87ffa00cad2 (patch) | |
| tree | e592257f11f2e1a81a47ea7e168bf461f2a3225e /lib | |
| parent | dca7fb2225ea5bd8452c51d4167962f2838389f8 (diff) | |
| download | android-node-v8-710110788b92311a9a012ede812ac87ffa00cad2.tar.gz android-node-v8-710110788b92311a9a012ede812ac87ffa00cad2.tar.bz2 android-node-v8-710110788b92311a9a012ede812ac87ffa00cad2.zip | |
assert: fix actual & expected input
This makes sure the actual and expected values on the error thrown
by `assert.throws` etc. are always as they should be.
PR-URL: https://github.com/nodejs/node/pull/19925
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/assert.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/assert.js b/lib/assert.js index 0a505d553a..9c0e465ab8 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -485,7 +485,7 @@ function expectsError(stackStartFn, actual, error, message) { ); } message = error; - error = null; + error = undefined; } if (actual === NO_EXCEPTION_SENTINEL) { @@ -496,7 +496,7 @@ function expectsError(stackStartFn, actual, error, message) { details += message ? `: ${message}` : '.'; const fnType = stackStartFn === rejects ? 'rejection' : 'exception'; innerFail({ - actual, + actual: undefined, expected: error, operator: stackStartFn.name, message: `Missing expected ${fnType}${details}`, @@ -514,7 +514,7 @@ function expectsNoError(stackStartFn, actual, error, message) { if (typeof error === 'string') { message = error; - error = null; + error = undefined; } if (!error || expectedException(actual, error)) { |