Fix mismatch createConnection and Socket.connect

net.createConnection() is wrapper for net.Socket.connect(),
but There is mismatch between them.

net.createConnection(port, [host])
net.Socket.connect(port, [host], [callback])

Fixes #1208.

2 files changed, 9 insertions, 5 deletions

diff --git a/lib/net_legacy.js b/lib/net_legacy.js
index 826d69f4ae..941c80eb3d 100644
--- a/lib/net_legacy.js
+++ b/lib/net_legacy.js
@@ -261,9 +261,9 @@ Socket.prototype.open = function(fd, type) {
 };
 
 
-exports.createConnection = function(port, host) {
+exports.createConnection = function(port, host, callback) {
   var s = new Socket();
-  s.connect(port, host);
+  s.connect(port, host, callback);
   return s;
 };
 
diff --git a/lib/net_uv.js b/lib/net_uv.js
index f8ef412b36..f13322d6d4 100644
--- a/lib/net_uv.js
+++ b/lib/net_uv.js
@@ -24,9 +24,9 @@ exports.createServer = function() {
 };
 
 
-exports.connect = exports.createConnection = function(port, host) {
+exports.connect = exports.createConnection = function(port, host /* [cb] */ ) {
   var s = new Socket();
-  s.connect(port, host);
+  s.connect(port, host, arguments[2]);
   return s;
 };
 
@@ -284,9 +284,13 @@ function afterWrite(status, handle, req, buffer) {
 }
 
 
-Socket.prototype.connect = function(port, host) {
+Socket.prototype.connect = function(port, host /* [cb] */) {
   var self = this;
 
+  if (typeof arguments[2] === 'function') {
+    self.on('connect', arguments[2]);
+  }
+
   timers.active(this);
 
   require('dns').lookup(host, function(err, ip, addressType) {