diff options
| author | Michaël Zasso <targos@protonmail.com> | 2019-08-28 10:05:32 +0200 |
|---|---|---|
| committer | Myles Borins <myles.borins@gmail.com> | 2019-10-07 03:20:07 -0400 |
| commit | 5981fb7faa13de95550b01272ebfbd8a5220aadb (patch) | |
| tree | b8d3f8f11b09c43f02a8133a643c92d1c1582d28 /lib | |
| parent | 16765023182486725b8cd9781c18d373de66df28 (diff) | |
| download | android-node-v8-5981fb7faa13de95550b01272ebfbd8a5220aadb.tar.gz android-node-v8-5981fb7faa13de95550b01272ebfbd8a5220aadb.tar.bz2 android-node-v8-5981fb7faa13de95550b01272ebfbd8a5220aadb.zip | |
assert: fix line number calculation after V8 upgrade
PR-URL: https://github.com/nodejs/node/pull/29694
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/assert.js | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/assert.js b/lib/assert.js index a83dba770e..d307582d1f 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -269,7 +269,7 @@ function getErrMessage(message, fn) { const call = err.stack[0]; const filename = call.getFileName(); - const line = call.getLineNumber() - 1; + let line = call.getLineNumber() - 1; let column = call.getColumnNumber() - 1; let identifier; let code; @@ -289,6 +289,9 @@ function getErrMessage(message, fn) { return message; } code = String(fn); + // For functions created with the Function constructor, V8 does not count + // the lines containing the function header. + line += 2; identifier = `${code}${line}${column}`; } |