http: remove duplicate parser unset

freeParser already unsets parser property of socket if socket is passed
in specifically. There's no need to do this twice.

PR-URL: https://github.com/nodejs/node/pull/20126
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

2 files changed, 1 insertions, 3 deletions

diff --git a/lib/_http_common.js b/lib/_http_common.js
index 7eb37511bd..ab075dc817 100644
--- a/lib/_http_common.js
+++ b/lib/_http_common.js
@@ -191,8 +191,6 @@ function freeParser(parser, req, socket) {
     if (parser._consumed)
       parser.unconsume();
     parser._consumed = false;
-    if (parser.socket)
-      parser.socket.parser = null;
     parser.socket = null;
     parser.incoming = null;
     parser.outgoing = null;
diff --git a/lib/_http_server.js b/lib/_http_server.js
index 1d6cada327..bf228de643 100644
--- a/lib/_http_server.js
+++ b/lib/_http_server.js
@@ -522,7 +522,7 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
     socket.removeListener('error', socketOnError);
     unconsume(parser, socket);
     parser.finish();
-    freeParser(parser, req, null);
+    freeParser(parser, req, socket);
     parser = null;
 
     var eventName = req.method === 'CONNECT' ? 'connect' : 'upgrade';