summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-10-15 01:32:16 +0200
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-10-18 05:20:59 +0200
commit4e9e0d339efa46316d90d6f2618afd0c0fc6cd34 (patch)
tree3fc78435ae6c87ad0b74f49176a590b4da5a8931 /lib
parentc1b9be53c89a7ac11c01905a4477785a6154512b (diff)
downloadandroid-node-v8-4e9e0d339efa46316d90d6f2618afd0c0fc6cd34.tar.gz
android-node-v8-4e9e0d339efa46316d90d6f2618afd0c0fc6cd34.tar.bz2
android-node-v8-4e9e0d339efa46316d90d6f2618afd0c0fc6cd34.zip
stream: undo internalBinding() conversion in compat mechanism
PR-URL: https://github.com/nodejs/node/pull/23662 Refs: https://github.com/nodejs/node/pull/22675 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib')
-rw-r--r--lib/stream.js5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/stream.js b/lib/stream.js
index 52c0e50582..f7e47df731 100644
--- a/lib/stream.js
+++ b/lib/stream.js
@@ -49,7 +49,10 @@ try {
} else {
// This throws for Node < 4.2.0 because there's no util binding and
// returns undefined for Node < 7.4.0.
- Stream._isUint8Array = internalBinding('util').isUint8Array;
+ // Please do not convert process.binding() to internalBinding() here.
+ // This is for compatibility with older versions when loaded as
+ // readable-stream.
+ Stream._isUint8Array = process.binding('util').isUint8Array;
}
} catch (e) {
}