fs: throw errors from fs.symlinkSync in JS

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 14 insertions, 2 deletions

diff --git a/lib/fs.js b/lib/fs.js
index 0103500f0b..c75a8501b6 100644
--- a/lib/fs.js
+++ b/lib/fs.js
@@ -1220,6 +1220,7 @@ fs.symlink = function(target, path, type_, callback_) {
   const flags = stringToSymlinkType(type);
   const req = new FSReqWrap();
   req.oncomplete = callback;
+
   binding.symlink(preprocessSymlinkDestination(target, type, path),
                   pathModule.toNamespacedPath(path), flags, req);
 };
@@ -1234,8 +1235,19 @@ fs.symlinkSync = function(target, path, type) {
   validatePath(target, 'target');
   validatePath(path);
   const flags = stringToSymlinkType(type);
-  return binding.symlink(preprocessSymlinkDestination(target, type, path),
-                         pathModule.toNamespacedPath(path), flags);
+
+  const ctx = { path: target, dest: path };
+  binding.symlink(preprocessSymlinkDestination(target, type, path),
+                  pathModule.toNamespacedPath(path), flags, undefined, ctx);
+
+  if (ctx.errno !== undefined) {
+    throw new errors.uvException(ctx);
+  } else if (ctx.error) {
+    // TODO(joyeecheung): this is an encoding error usually caused by memory
+    // problems. We need to figure out proper error code(s) for this.
+    Error.captureStackTrace(ctx.error);
+    throw ctx.error;
+  }
 };
 
 fs.link = function(existingPath, newPath, callback) {