diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-11-30 10:17:51 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-12-03 13:03:43 +0100 |
| commit | 2eff120f6d4d88c29e692f67e396916ea71418e2 (patch) | |
| tree | 13c7463b4ea3ac01b1773a990d53b797c5d8103f /lib | |
| parent | e00639e57f86f4707f665975ca7aea5ca8799399 (diff) | |
| download | android-node-v8-2eff120f6d4d88c29e692f67e396916ea71418e2.tar.gz android-node-v8-2eff120f6d4d88c29e692f67e396916ea71418e2.tar.bz2 android-node-v8-2eff120f6d4d88c29e692f67e396916ea71418e2.zip | |
assert: fix loose deepEqual map comparison
Loose map comparison had an logic error. It will now be properly
compared.
PR-URL: https://github.com/nodejs/node/pull/24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/internal/util/comparisons.js | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js index 9adffea09a..43a8921f65 100644 --- a/lib/internal/util/comparisons.js +++ b/lib/internal/util/comparisons.js @@ -416,9 +416,7 @@ function mapMightHaveLoosePrim(a, b, prim, item, memo) { !innerDeepEqual(item, curB, false, memo)) { return false; } - const curA = a.get(altValue); - return curA === undefined && a.has(altValue) || - innerDeepEqual(item, curA, false, memo); + return !a.has(altValue) && innerDeepEqual(item, curB, false, memo); } function setEquiv(a, b, strict, memo) { |