summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2018-10-02 23:36:18 -0400
committercjihrig <cjihrig@gmail.com>2018-10-08 23:43:00 -0400
commit2ec57a71343cdb725d45801508fceb0a266a9324 (patch)
tree4332972d2894043e6e4b09f6d5b7719514666749 /lib
parent2498c7b18b6e82fec15c7672bf774e5f94a08b52 (diff)
downloadandroid-node-v8-2ec57a71343cdb725d45801508fceb0a266a9324.tar.gz
android-node-v8-2ec57a71343cdb725d45801508fceb0a266a9324.tar.bz2
android-node-v8-2ec57a71343cdb725d45801508fceb0a266a9324.zip
buffer: unconditionally use internalBinding
With the removal of test-buffer-bindingobj-no-zerofill.js, internalBinding can be used unconditionally to assign isAnyArrayBuffer(). PR-URL: https://github.com/nodejs/node/pull/23234 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'lib')
-rw-r--r--lib/buffer.js9
1 files changed, 1 insertions, 8 deletions
diff --git a/lib/buffer.js b/lib/buffer.js
index 2ceb7ce1c9..c7ffa42a54 100644
--- a/lib/buffer.js
+++ b/lib/buffer.js
@@ -37,14 +37,7 @@ const {
kMaxLength,
kStringMaxLength
} = process.binding('buffer');
-// We cannot use internalBinding unconditionally here because of the way
-// that test/parallel/test-buffer-bindingobj-no-zerofill.js is written.
-let isAnyArrayBuffer;
-try {
- isAnyArrayBuffer = internalBinding('types').isAnyArrayBuffer;
-} catch (e) {
- isAnyArrayBuffer = require('util').types.isAnyArrayBuffer;
-}
+const { isAnyArrayBuffer } = internalBinding('types');
const {
customInspectSymbol,
isInsideNodeModules,