lib: trigger uncaught exception handler for microtasks

PR-URL: https://github.com/nodejs/node/pull/23794
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>

2 files changed, 31 insertions, 21 deletions

diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 2d99885750..bc87801be2 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -24,7 +24,8 @@
                                 _umask, _initgroups, _setegid, _seteuid,
                                 _setgid, _setuid, _setgroups,
                                 _shouldAbortOnUncaughtToggle },
-                              { internalBinding, NativeModule }) {
+                              { internalBinding, NativeModule },
+                              triggerFatalException) {
   const exceptionHandlerState = { captureFn: null };
   const isMainThread = internalBinding('worker').threadId === 0;
 
@@ -538,8 +539,9 @@
       get: () => {
         process.emitWarning('queueMicrotask() is experimental.',
                             'ExperimentalWarning');
-        const { queueMicrotask } =
+        const { setupQueueMicrotask } =
           NativeModule.require('internal/queue_microtask');
+        const queueMicrotask = setupQueueMicrotask(triggerFatalException);
         Object.defineProperty(global, 'queueMicrotask', {
           value: queueMicrotask,
           writable: true,
diff --git a/lib/internal/queue_microtask.js b/lib/internal/queue_microtask.js
index e9cc414389..6421e7f940 100644
--- a/lib/internal/queue_microtask.js
+++ b/lib/internal/queue_microtask.js
@@ -5,27 +5,35 @@ const { AsyncResource } = require('async_hooks');
 const { getDefaultTriggerAsyncId } = require('internal/async_hooks');
 const { enqueueMicrotask } = internalBinding('util');
 
-// declared separately for name, arrow function to prevent construction
-const queueMicrotask = (callback) => {
-  if (typeof callback !== 'function') {
-    throw new ERR_INVALID_ARG_TYPE('callback', 'function', callback);
-  }
+const setupQueueMicrotask = (triggerFatalException) => {
+  const queueMicrotask = (callback) => {
+    if (typeof callback !== 'function') {
+      throw new ERR_INVALID_ARG_TYPE('callback', 'function', callback);
+    }
 
-  const asyncResource = new AsyncResource('Microtask', {
-    triggerAsyncId: getDefaultTriggerAsyncId(),
-    requireManualDestroy: true,
-  });
+    const asyncResource = new AsyncResource('Microtask', {
+      triggerAsyncId: getDefaultTriggerAsyncId(),
+      requireManualDestroy: true,
+    });
 
-  enqueueMicrotask(() => {
-    asyncResource.runInAsyncScope(() => {
-      try {
-        callback();
-      } catch (e) {
-        process.emit('error', e);
-      }
+    enqueueMicrotask(() => {
+      asyncResource.runInAsyncScope(() => {
+        try {
+          callback();
+        } catch (error) {
+          // TODO(devsnek) remove this if
+          // https://bugs.chromium.org/p/v8/issues/detail?id=8326
+          // is resolved such that V8 triggers the fatal exception
+          // handler for microtasks
+          triggerFatalException(error);
+        } finally {
+          asyncResource.emitDestroy();
+        }
+      });
     });
-    asyncResource.emitDestroy();
-  });
+  };
+
+  return queueMicrotask;
 };
 
-module.exports = { queueMicrotask };
+module.exports = { setupQueueMicrotask };