lib: make queueMicrotask faster

No longer create an additional scope within queueMicrotask
in order to improve performance.

PR-URL: https://github.com/nodejs/node/pull/27032
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 21 insertions, 15 deletions

diff --git a/lib/internal/process/task_queues.js b/lib/internal/process/task_queues.js
index 65ac093802..5f5ca5a008 100644
--- a/lib/internal/process/task_queues.js
+++ b/lib/internal/process/task_queues.js
@@ -37,6 +37,8 @@ const {
 } = require('internal/errors').codes;
 const FixedQueue = require('internal/fixed_queue');
 
+const FunctionBind = Function.call.bind(Function.prototype.bind);
+
 // *Must* match Environment::TickInfo::Fields in src/env.h.
 const kHasTickScheduled = 0;
 
@@ -149,28 +151,32 @@ function createMicrotaskResource() {
   });
 }
 
+function runMicrotask() {
+  this.runInAsyncScope(() => {
+    const callback = this.callback;
+    try {
+      callback();
+    } catch (error) {
+      // TODO(devsnek) remove this if
+      // https://bugs.chromium.org/p/v8/issues/detail?id=8326
+      // is resolved such that V8 triggers the fatal exception
+      // handler for microtasks
+      triggerFatalException(error);
+    } finally {
+      this.emitDestroy();
+    }
+  });
+}
+
 function queueMicrotask(callback) {
   if (typeof callback !== 'function') {
     throw new ERR_INVALID_ARG_TYPE('callback', 'function', callback);
   }
 
   const asyncResource = createMicrotaskResource();
+  asyncResource.callback = callback;
 
-  enqueueMicrotask(() => {
-    asyncResource.runInAsyncScope(() => {
-      try {
-        callback();
-      } catch (error) {
-        // TODO(devsnek) remove this if
-        // https://bugs.chromium.org/p/v8/issues/detail?id=8326
-        // is resolved such that V8 triggers the fatal exception
-        // handler for microtasks
-        triggerFatalException(error);
-      } finally {
-        asyncResource.emitDestroy();
-      }
-    });
-  });
+  enqueueMicrotask(FunctionBind(runMicrotask, asyncResource));
 }
 
 module.exports = {