util: fix isInsideNodeModules inside error

When isInsideNodeModules gets called while already processing
another stack trace, V8 will not call prepareStackTrace again.
This used to cause Node.js to just crash — fix it by checking
for expected return type of the stack (Array).

PR-URL: https://github.com/nodejs/node/pull/20266
Fixes: https://github.com/nodejs/node/issues/20258
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 files changed, 10 insertions, 9 deletions

diff --git a/lib/internal/util.js b/lib/internal/util.js
index ce25317b77..071563a737 100644
--- a/lib/internal/util.js
+++ b/lib/internal/util.js
@@ -356,16 +356,17 @@ function isInsideNodeModules() {
 
   // Iterate over all stack frames and look for the first one not coming
   // from inside Node.js itself:
-  for (const frame of stack) {
-    const filename = frame.getFileName();
-    // If a filename does not start with / or contain \,
-    // it's likely from Node.js core.
-    if (!/^\/|\\/.test(filename))
-      continue;
-    return kNodeModulesRE.test(filename);
+  if (Array.isArray(stack)) {
+    for (const frame of stack) {
+      const filename = frame.getFileName();
+      // If a filename does not start with / or contain \,
+      // it's likely from Node.js core.
+      if (!/^\/|\\/.test(filename))
+        continue;
+      return kNodeModulesRE.test(filename);
+    }
   }
-
-  return false;  // This should be unreachable.
+  return false;
 }