summaryrefslogtreecommitdiff
path: root/lib/zlib.js
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-12-10 00:11:29 +0100
committerAnna Henningsen <anna@addaleax.net>2018-12-12 17:09:53 +0100
commit9a2654601e58cb738463ea4a195400dd0cdd37ad (patch)
tree0826c3b6a402b1029300eeaef10d5375d721a6f6 /lib/zlib.js
parenta0bdeb553068d844dbe6005f0080620f1d0a673f (diff)
downloadandroid-node-v8-9a2654601e58cb738463ea4a195400dd0cdd37ad.tar.gz
android-node-v8-9a2654601e58cb738463ea4a195400dd0cdd37ad.tar.bz2
android-node-v8-9a2654601e58cb738463ea4a195400dd0cdd37ad.zip
zlib: throw TypeError if callback is missing
Get a proper stack trace when no callback is passed. PR-URL: https://github.com/nodejs/node/pull/24929 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib/zlib.js')
-rw-r--r--lib/zlib.js2
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/zlib.js b/lib/zlib.js
index 0eb071a372..183ff7bfcf 100644
--- a/lib/zlib.js
+++ b/lib/zlib.js
@@ -73,6 +73,8 @@ for (var ck = 0; ck < ckeys.length; ck++) {
}
function zlibBuffer(engine, buffer, callback) {
+ if (typeof callback !== 'function')
+ throw new ERR_INVALID_ARG_TYPE('callback', 'function', callback);
// Streams do not support non-Buffer ArrayBufferViews yet. Convert it to a
// Buffer without copying.
if (isArrayBufferView(buffer) &&