diff options
| author | MaleDong <maledong_github@outlook.com> | 2018-08-04 09:16:22 +0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-08-07 10:49:10 -0700 |
| commit | 493e6d45d9b26d902ddc67965f5989500997585c (patch) | |
| tree | a005d84e8e905f727f87bfb7144be62dac43d7ef /lib/zlib.js | |
| parent | e570ae79f5b1d74fed52d2aed7f014caaa0836dd (diff) | |
| download | android-node-v8-493e6d45d9b26d902ddc67965f5989500997585c.tar.gz android-node-v8-493e6d45d9b26d902ddc67965f5989500997585c.tar.bz2 android-node-v8-493e6d45d9b26d902ddc67965f5989500997585c.zip | |
zlib: remove unused parameters
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter
function only has two parameters, so `lower` and `upper` don't need to
be passed for validation.
PR-URL: https://github.com/nodejs/node/pull/22115
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'lib/zlib.js')
| -rw-r--r-- | lib/zlib.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/zlib.js b/lib/zlib.js index 4e82c6f245..ca5f05884a 100644 --- a/lib/zlib.js +++ b/lib/zlib.js @@ -198,12 +198,12 @@ function checkFiniteNumber(number, name) { throw err; } -// 1. Returns def for undefined and NaN +// 1. Returns def for number when it's undefined or NaN // 2. Returns number for finite numbers >= lower and <= upper // 3. Throws ERR_INVALID_ARG_TYPE for non-numbers // 4. Throws ERR_OUT_OF_RANGE for infinite numbers or numbers > upper or < lower function checkRangesOrGetDefault(number, name, lower, upper, def) { - if (!checkFiniteNumber(number, name, lower, upper)) { + if (!checkFiniteNumber(number, name)) { return def; } if (number < lower || number > upper) { |