vm: never abort on caught syntax error

Keep track of C++ `TryCatch` state to avoid aborting when
an exception is thrown inside one, and re-throw in JS
to make sure the exception is being picked up a second time by
a second uncaught exception handler, if necessary.

Add a bit of a hack to `AppendExceptionLine` to avoid overriding
the line responsible for re-throwing the exception.

PR-URL: https://github.com/nodejs/node/pull/17394
Fixes: https://github.com/nodejs/node/issues/13258
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 14 insertions, 1 deletions

diff --git a/lib/vm.js b/lib/vm.js
index b34f10dbee..2f110b2db2 100644
--- a/lib/vm.js
+++ b/lib/vm.js
@@ -22,7 +22,7 @@
 'use strict';
 
 const {
-  ContextifyScript: Script,
+  ContextifyScript,
   kParsingContext,
 
   makeContext,
@@ -39,6 +39,19 @@ const {
 // - isContext(sandbox)
 // From this we build the entire documented API.
 
+class Script extends ContextifyScript {
+  constructor(code, options) {
+    // Calling `ReThrow()` on a native TryCatch does not generate a new
+    // abort-on-uncaught-exception check. A dummy try/catch in JS land
+    // protects against that.
+    try {
+      super(code, options);
+    } catch (e) {
+      throw e; /* node-do-not-add-exception-line */
+    }
+  }
+}
+
 const realRunInThisContext = Script.prototype.runInThisContext;
 const realRunInContext = Script.prototype.runInContext;