diff options
| author | MaleDong <maledong_github@outlook.com> | 2018-07-20 15:55:27 +0800 |
|---|---|---|
| committer | Sam Ruby <rubys@intertwingly.net> | 2018-08-21 00:28:47 -0400 |
| commit | 6e9e150b6a1746df899b68158dd540b4e790eff8 (patch) | |
| tree | 80593f4063402ede7f6919f0e9b30defd3603851 /lib/util.js | |
| parent | 36696cfe8479f3fd511124b60c24b4a6a33a80da (diff) | |
| download | android-node-v8-6e9e150b6a1746df899b68158dd540b4e790eff8.tar.gz android-node-v8-6e9e150b6a1746df899b68158dd540b4e790eff8.tar.bz2 android-node-v8-6e9e150b6a1746df899b68158dd540b4e790eff8.zip | |
util: Fix number format for `pad`
`pad` is now using `toString(10)`, actually we don't need to do this. As for https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toString, `toString(N)` is a radix converter, which isn't proper here for time conversion.
PR-URL: https://github.com/nodejs/node/pull/21906
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Diffstat (limited to 'lib/util.js')
| -rw-r--r-- | lib/util.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/util.js b/lib/util.js index 33c4cdfff7..fa96ade26a 100644 --- a/lib/util.js +++ b/lib/util.js @@ -1349,7 +1349,7 @@ function isPrimitive(arg) { } function pad(n) { - return n < 10 ? `0${n.toString(10)}` : n.toString(10); + return n.toString().padStart(2, '0'); } const months = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', |