diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-20 12:18:16 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-27 17:05:16 +0100 |
commit | ce265908eb84aa0518dcadc57d59e7fbb353a256 (patch) | |
tree | 760332287d57d88195d68ff45f1db1ee2d619e56 /lib/url.js | |
parent | 28e2c3771d3da014c35b57cc55f7808627e43f2d (diff) | |
download | android-node-v8-ce265908eb84aa0518dcadc57d59e7fbb353a256.tar.gz android-node-v8-ce265908eb84aa0518dcadc57d59e7fbb353a256.tar.bz2 android-node-v8-ce265908eb84aa0518dcadc57d59e7fbb353a256.zip |
http2: remove side effects from validateSettings
The function did not only validate the input so far but it also made
a copy of the input object and returned that copy to the callee
function. That copy was not necessary for all call sites and it was
not obvious that the function did not only validate the input but
that it also returned a copy of it. This makes sure the function does
nothing more than validation and copying is happening in the callee
function when required.
PR-URL: https://github.com/nodejs/node/pull/26809
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/url.js')
0 files changed, 0 insertions, 0 deletions