diff options
| author | ZYSzys <17367077526@163.com> | 2018-12-11 23:24:22 +0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-12-13 17:22:43 -0800 |
| commit | a35bd62ae17f9f673430dd90a57ef9bf9f42012a (patch) | |
| tree | 0d259d81ed2044ba14cd02a688e3c3f2b9e7b3b9 /lib/url.js | |
| parent | e9892698655af635f665b7250277fa4c68321313 (diff) | |
| download | android-node-v8-a35bd62ae17f9f673430dd90a57ef9bf9f42012a.tar.gz android-node-v8-a35bd62ae17f9f673430dd90a57ef9bf9f42012a.tar.bz2 android-node-v8-a35bd62ae17f9f673430dd90a57ef9bf9f42012a.zip | |
lib: refactor argument validation using validateString
PR-URL: https://github.com/nodejs/node/pull/24960
Refs: https://github.com/nodejs/node/pull/22101
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib/url.js')
| -rw-r--r-- | lib/url.js | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/url.js b/lib/url.js index 29dec5cc5f..c34eee638c 100644 --- a/lib/url.js +++ b/lib/url.js @@ -31,6 +31,7 @@ const { SafeSet } = require('internal/safe_globals'); const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes; +const { validateString } = require('internal/validators'); // This ensures setURLConstructor() is called before the native // URL::ToObject() method is used. @@ -150,9 +151,7 @@ function urlParse(url, parseQueryString, slashesDenoteHost) { } Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) { - if (typeof url !== 'string') { - throw new ERR_INVALID_ARG_TYPE('url', 'string', url); - } + validateString(url, 'url'); // Copy chrome, IE, opera backslash-handling behavior. // Back slashes before the query string get converted to forward slashes |